perf: hide GetObjectResumableUploadOffset interface #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constwz
force-pushed
the
perf-hide-ResumableUploadOffset
branch
2 times, most recently
from
9f501a0 to
d9dedc2
Compare
clydemeng
reviewed
Jan 24, 2024
client/api_object.go
Outdated
| @@ -56,7 +56,7 @@ type IObjectClient interface { | |||
| ComputeHashRoots(reader io.Reader, isSerial bool) ([][]byte, int64, storageTypes.RedundancyType, error) | |||
| CreateFolder(ctx context.Context, bucketName, objectName string, opts types.CreateObjectOptions) (string, error) | |||
| GetObjectUploadProgress(ctx context.Context, bucketName, objectName string) (string, error) | |||
| GetObjectResumableUploadOffset(ctx context.Context, bucketName, objectName string) (uint64, error) | |||
| //GetObjectResumableUploadOffset(ctx context.Context, bucketName, objectName string) (uint64, error) | |||
e2e/e2e_storage_test.go
Outdated
| offset, err := s.Client.GetObjectResumableUploadOffset(s.ClientContext, bucketName, objectName) | ||
| s.Require().NoError(err) | ||
| s.Require().Equal(offset, partSize16MB) | ||
| //offset, err := s.Client.getObjectResumableUploadOffset(s.ClientContext, bucketName, objectName) |
constwz
force-pushed
the
perf-hide-ResumableUploadOffset
branch
from
d9dedc2 to
e84e32b
Compare
clydemeng
approved these changes
Jan 24, 2024
flywukong
approved these changes
Jan 24, 2024
ruojunm
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a description of your changes here...
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: